Fixed: issue with reordering of rules not being saved by updating the sequence of rules just after reordering instead of updating them before saving(#283) #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#283
Short Description and Why It's Useful
Updating the sequence of rules in the original list just after reordering is completed, as previously the list was updated before saving causing the issue of rules diff not being calculated correctly.
Also fixed an issue that, after reordering if we change the status of any rule then the reordering is lost.
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance